Re: [PATCH 3/3] ARM: Kirkwood: DT: Add missing vendor prefix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, Mar 03, 2014 at 10:05:22PM -0500, Jason Cooper wrote:
> Andrew,
> 
> Couple of stupid questions:
> 
>  - I haven't seen 0/1 nor 1/1 show up anywhere (dt, lakml, inbox), am I
>    missing something?

Humm, i will check, and do a resend if needed.

 
> On Sun, Mar 02, 2014 at 04:24:15PM +0100, Andrew Lunn wrote:
> > Add vendor prefixes to compatible strings where they are missing.
> > 
> > Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
> > ---
> >  arch/arm/boot/dts/kirkwood-b3.dts              | 2 +-
> >  arch/arm/boot/dts/kirkwood-cloudbox.dts        | 2 +-
> >  arch/arm/boot/dts/kirkwood-dreamplug.dts       | 2 +-
> >  arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 2 +-
> >  arch/arm/boot/dts/kirkwood-ns2-common.dtsi     | 2 +-
> >  arch/arm/boot/dts/kirkwood-nsa310.dts          | 2 +-
> >  arch/arm/boot/dts/kirkwood-nsa310a.dts         | 2 +-
> >  arch/arm/boot/dts/kirkwood-openblocks_a6.dts   | 2 +-
> >  arch/arm/boot/dts/kirkwood-openblocks_a7.dts   | 2 +-
> >  9 files changed, 9 insertions(+), 9 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/kirkwood-b3.dts b/arch/arm/boot/dts/kirkwood-b3.dts
> > index 40791053106b..6becedebaa4e 100644
> > --- a/arch/arm/boot/dts/kirkwood-b3.dts
> > +++ b/arch/arm/boot/dts/kirkwood-b3.dts
> > @@ -75,7 +75,7 @@
> >  			m25p16@0 {
> >  				#address-cells = <1>;
> >  				#size-cells = <1>;
> > -				compatible = "m25p16";
> > +				compatible = "st,m25p16";
> 
> Have you checked that the drivers for each of these changes already
> support the new compatible strings?

I2c and MTD ignore the vendor string when performing matches. However,
checkpatch.pl does not. It is also technically correct to have a
vendor string.

       Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux