Hi Tony, Am Dienstag, 31. Juli 2018, 09:57:28 CEST schrieb Tony Xie: > Add device tree bindings documentation for Rockchip's RK809 & RK817 PMIC. > > Signed-off-by: Tony Xie <tony.xie@xxxxxxxxxxxxxx> I don't see the devicetree binding maintainers listed in the recipient list, so adding them in the next iteration might increase your chances to get an Ack on the binding. scripts/get_maintainer.pl -f Documentation/devicetree/bindings lists Rob Herring <robh+dt@xxxxxxxxxx> Mark Rutland <mark.rutland@xxxxxxx> as the main dt maintainers. [...] > @@ -99,6 +147,13 @@ number as described in RK818 datasheet. > - HDMI_SWITCH > - OTG_SWITCH > > +There are three pins needed to config, named "gpio_ts" "gpio_gt" "gpio_slp". > + The gpio_gt and gpio_ts pins support the gpio function. > + The gpio_slp pin is for controlling the pmic states, as below: > + - reset > + - power down > + - sleep > + Is this common for all rk8xx pmics or just the two new ones? As the paragraph above makes it sound like these are present on all and I didn't find mention of them in the datasheets for previous pmics I have. Also to me it is not clear in what way these should be used and I didn't find any mention of them at all in the rest of your series. Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
