On 08/01/2018 05:53 PM, Arun Parameswaran wrote: > Hi, > The patchset is based on David Miller's "net-next" repo. > > The patchset extends the Broadcom iProc mdio mux to add support for > suspend/resume and the ability to configure the internal clock > divider. The patchset also sets the scan control register to > disable external master access. > > The base address of the mdio-mux-bcm-iproc is modified to point to the > start of the mdio block's address space, to be able to access all the > mdio's registers. The missing registers are required to configure the > internal clock divider registers in some of the Broadcom SoC's. Looks ready to me now, thanks for your persistence addressing feedback. > > Changes from v3: > - Removed 'platform_set_drvdata(pdev, NULL)' call (in patch 5/8) > - Fixed the return code handling for the devm_clk_get() call (in patch > 7/8) > - Added Reviewed-by tag to Patch 8/8 > > Changes from v2: > - Addressed Andrew's comments: > - Moved to using devm_mdiobus_alloc. Added this as a separate patch. > - Changed to reverse christmas tree order for variable declaration in > the clock patch > - Addressed Florian's comments: > - Removed null checks for the clock before calling unprepare in > both clock and pm patches. > - Added check for EPROBE_DEFER when fetching the clock in the clock > patch. > - The patch to use the devm API has been added before the clock & pm > patches. This patch is now patch '5' in the series. > - Added reviewed-by tags to commit messages of patches which remain > unmodified from v2. > - Modified PM patch to use platform_get_drvdata() in suspend/resume > API's, similar to the recent fix that went in for the remove() > api. > > Changes from v1: > - Addressed Andrew's comments. > - Reworked the patches to be based on 'net-next' > - Removed 'fixes' from the commit messages, the changes are related > to the new features being added. > - Maintained backward compatibility to older dt-blob's specifying > base addresse with an offset. The correction is applied in the > driver and a message is printed to update the dt-blob. > - Re-worked and re-ordered the last four patches (4-7). > - Added setting of the scan control register as a new patch > - Added a call to 'clk_prepare_enable()' in the patch that adds > the clock config support, removed the debug message when clock > is not passed. > - Simplified the pm support patch (removed the array used for the > save/restore logic). > > Thanks > > Arun Parameswaran (8): > dt-bindings: net: Fix Broadcom iProc mdio mux driver base address > net: phy: Fix the register offsets in Broadcom iProc mdio mux driver > arm64: dts: Fix the base address of the Broadcom iProc mdio mux > net: phy: Disable external master access in bcm mdio mux driver > net: phy: Use devm api for mdio bus allocation in bcm iproc mdio mux > dt-bindings: net: Add clock handle to Broadcom iProc mdio mux > net: phy: Add support to configure clock in Broadcom iProc mdio mux > net: phy: Add pm support to Broadcom iProc mdio mux driver > > .../bindings/net/brcm,mdio-mux-iproc.txt | 7 +- > arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 4 +- > .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 4 +- > drivers/net/phy/mdio-mux-bcm-iproc.c | 108 ++++++++++++++++++--- > 4 files changed, 106 insertions(+), 17 deletions(-) > -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
