On Wed, Aug 1, 2018 at 2:57 AM Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> wrote: > > Thanks for the review, > > On 31/07/18 21:45, Rob Herring wrote: > > On Fri, Jul 27, 2018 at 01:17:59PM +0100, Srinivas Kandagatla wrote: > >> WCD9335 supports two lines of irqs INTR1 and INTR2. > >> Multiple interrupts are muxed via these lines. > >> INTR1 consists of all possible interrupt sources like: > >> Ear OCP, HPH OCP, MBHC, MAD, VBAT, and SVA > >> INTR2 is a subset of first interrupt sources like MAD, VBAT, and SVA > >> > >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > >> --- > >> drivers/mfd/Makefile | 2 +- > >> drivers/mfd/wcd9335-core.c | 9 ++ > >> drivers/mfd/wcd9335-irq.c | 172 ++++++++++++++++++++++++++++++++++++ > >> include/dt-bindings/mfd/wcd9335.h | 43 +++++++++ > > > > I'm confused why these are defined here. The binding for the wc9335 is > > not an interrupt-controller. > > I can move this defines to include/linux/mfd/wcd9335/wcd9335.h as there > are no active users for this, but I was hoping that these can be used > in DT in future. > > WCD9335 is an interrupt controller too. It muxes multiple interrupts via > a gpio line interrupt. > > I did mention this in the bindings. Then the header belongs in the binding patch. I don't recall child nodes being defined though and you don't need to be a interrupt-controller (in DT) without them. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
