On 1 August 2018 at 11:36, Ludovic Barre <ludovic.Barre@xxxxxx> wrote: > From: Ludovic Barre <ludovic.barre@xxxxxx> > > This patch fixes qcom dma issue during mmci init. > Like init callback of qcom variant is not set, the qcom dma > is not correctly initialized and fail while dma transfer > ("buggy DMA detected. Taking evasive action"). > > Signed-off-by: Ludovic Barre <ludovic.barre@xxxxxx> > --- > drivers/mmc/host/mmci.c | 1 + > drivers/mmc/host/mmci.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c > index 71e9336..1841d250 100644 > --- a/drivers/mmc/host/mmci.c > +++ b/drivers/mmc/host/mmci.c > @@ -208,6 +208,7 @@ static struct variant_data variant_qcom = { > .mmcimask1 = true, > .start_err = MCI_STARTBITERR, > .opendrain = MCI_ROD, > + .init = qcom_variant_init, > }; > > /* Busy detection for the ST Micro variant */ > diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h > index 517591d..696a066 100644 > --- a/drivers/mmc/host/mmci.h > +++ b/drivers/mmc/host/mmci.h > @@ -338,3 +338,4 @@ struct mmci_host { > #endif > }; > > +void qcom_variant_init(struct mmci_host *host); This isn't needed. > -- > 2.7.4 > Anyway, we can just drop this patch from your series as I amended the patch causing the problem. I will continue to review the rest. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html