Hi Boris, On 1.8.2018 10:19, Boris Brezillon wrote: > Document Xilinx Clocking Wizard bindings. > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx> > --- > .../devicetree/bindings/clock/xlnx,clk-wizard.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/xlnx,clk-wizard.txt > > diff --git a/Documentation/devicetree/bindings/clock/xlnx,clk-wizard.txt b/Documentation/devicetree/bindings/clock/xlnx,clk-wizard.txt > new file mode 100644 > index 000000000000..1bf7a764f4a9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/xlnx,clk-wizard.txt > @@ -0,0 +1,28 @@ > +Device Tree Clock bindings for the "Clocking Wizard" IP provided by Xilinx > + > +This block can be used to generate up to 4 clock signals out of a single input > +clock. It embeds a PLL to generate an intermediate clock which then feeds 4 > +clock dividers whose divider value can be adjusted based on the user needs. > + > +Required properties: > + - #clock-cells: must be 1. The cell is encoding the id of the output clk > + (from 0 to xlnx,clk-wizard-num-outputs - 1) > + - compatible: must be "xlnx,clk-wizard-5.1" > + - clocks: 2 clocks are required > + - clock-names: should contain 2 clock names: "aclk" and "clkin". > + "aclk" is driving the register interface and "clk_in" is the > + input clock signal that is used by the PLL block > + - xlnx,clk-wizard-num-outputs: this describe the number of output clocks > + (chosen at synthesization time) > + - reg: registers used to configure the Clocking wizard block > + > +Example: > + > + clkwizard: clkwizard@43c20000 { > + compatible = "xlnx,clk-wizard-5.1"; > + reg = <0x43c20000 0x10000>; > + clocks = <&clkc 18>, <&clkc 18>; > + clock-names = "aclk", "clk_in1"; > + #clock-cells = <1>; > + xlnx,clk-wizard-num-outputs = <2>; > + }; > First of all this should be 1/2. The second is that this driver is already in staging area (drivers/staging/clocking-wizard) for a while. That's why please use this driver or send patches on the top of this. I know we have been doing some changes in this driver recently but not sure if they reach our tree or mainline. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html