> -----Original Message----- > From: Oleksij Rempel [mailto:o.rempel@xxxxxxxxxxxxxx] > Sent: Tuesday, July 31, 2018 10:12 PM > To: Shawn Guo <shawnguo@xxxxxxxxxx>; Fabio Estevam > <fabio.estevam@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Mark > Rutland <mark.rutland@xxxxxxx>; A.s. Dong <aisheng.dong@xxxxxxx>; > Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx>; Jassi Brar > <jassisinghbrar@xxxxxxxxx> > Cc: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>; kernel@xxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; dl-linux- > imx <linux-imx@xxxxxxx> > Subject: [PATCH v8 4/4] mailbox: Add support for i.MX7D messaging unit > > The Mailbox controller is able to send messages (up to 4 32 bit words) > between the endpoints. > I'm not sure but is this still valid after change to multi channels mode? We actually lost the HW capability to send messages up to 4 words in the multi channels mode. And such commit message probably will confuse people. Worth a improve? Otherwise this patch mostly is okay to me except a few bits already pointed out by Jassi. Regards Dong Aisheng -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html