Hi David, > -----Original Message----- > From: David Miller [mailto:davem@xxxxxxxxxxxxx] > Sent: Tuesday, July 31, 2018 12:26 AM > To: Y.b. Lu <yangbo.lu@xxxxxxx> > Cc: netdev@xxxxxxxxxxxxxxx; Madalin-cristian Bucur > <madalin.bucur@xxxxxxx>; richardcochran@xxxxxxxxx; robh+dt@xxxxxxxxxx; > shawnguo@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linuxppc-dev@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 3/3] ptp_qoriq: convert to use module parameters for > initialization > > From: Yangbo Lu <yangbo.lu@xxxxxxx> > Date: Mon, 30 Jul 2018 18:01:54 +0800 > > > +static unsigned int cksel = DEFAULT_CKSEL; module_param(cksel, uint, > > +0644); MODULE_PARM_DESC(cksel, "Select reference clock"); > > + > > +static unsigned int clk_src; > > +module_param(clk_src, uint, 0644); > > +MODULE_PARM_DESC(clk_src, "Reference clock frequency (if clocks > > +property not provided in dts)"); > > + > > +static unsigned int tmr_prsc = 2; > > +module_param(tmr_prsc, uint, 0644); > > +MODULE_PARM_DESC(tmr_prsc, "Output clock division/prescale factor"); > > + > > +static unsigned int tmr_fiper1 = 1000000000; module_param(tmr_fiper1, > > +uint, 0644); MODULE_PARM_DESC(tmr_fiper1, "Desired fixed interval > > +pulse period (ns)"); > > + > > +static unsigned int tmr_fiper2 = 100000; module_param(tmr_fiper2, > > +uint, 0644); MODULE_PARM_DESC(tmr_fiper2, "Desired fixed interval > > +pulse period (ns)"); > > Sorry, there is no way I am every applying something like this. Module > parameters are to be avoided at all costs. > > And you don't need it here, you have DTS, please use it. > > You are required to support the existing DTS cases, in order to avoid breaking > things, anyways. [Y.b. Lu] I get your point. Will drop module_param method. Thanks a lot for your suggestion. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
