Thanks for the quick response.. Please see my comments inline.... > -----Original Message----- > From: Michal Simek [mailto:michal.simek@xxxxxxxxxx] > Sent: Tuesday, July 31, 2018 5:48 PM > To: Nava kishore Manne <navam@xxxxxxxxxx>; robh+dt@xxxxxxxxxx; > mark.rutland@xxxxxxx; Michal Simek <michals@xxxxxxxxxx>; Soren Brinkmann > <sorenb@xxxxxxxxxx>; atull@xxxxxxxxxxxxxxxxxxxxx; > moritz.fischer@xxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Appana Durga > Kedareswara Rao <appanad@xxxxxxxxxx>; chinnikishore369@xxxxxxxxx > Cc: Nava kishore Manne <navam@xxxxxxxxxx> > Subject: Re: [RFC PATCH 1/2] ARM: dt: fpga: Added binding docs for Xilinx > zynqmp FPGA manager > > On 1.8.2018 12:04, Nava kishore Manne wrote: > > New bindings document for zynqmp fpga manager. > > > > Signed-off-by: Nava kishore Manne <navam@xxxxxxxxxx> > > --- > > .../devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,zynqmp- > pcap-fpga.txt > > > > diff --git a/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap- > fpga.txt b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap- > fpga.txt > > new file mode 100644 > > index 000000000000..0eac747747f5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt > > @@ -0,0 +1,9 @@ > > +Xilinx Zynqmp FPGA Manager > > This should be ZynqMP. > Will fix in the next version.. > > + > > +Required properties: > > +- compatible: should contain "xlnx,zynqmp-pcap-fpga" > > + > > +Example: > > + pcap: pcap@00 { > > no reason for address if there is no any below. > Will fix in the next version.... Regards, Navakishore. ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f