Hi Andrew,
On 18-07-28 02:22 PM, Andrew Lunn wrote:
>> @@ -198,10 +219,22 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
>> return PTR_ERR(md->base);
>> }
>>
>> + md->core_clk = devm_clk_get(&pdev->dev, NULL);
>> + if (IS_ERR(md->core_clk)) {
>> + md->core_clk = NULL;
>> + } else {
>> + rc = clk_prepare_enable(md->core_clk);
>> + if (rc) {
>> + dev_err(&pdev->dev, "failed to enable core clk\n");
>> + return rc;
>> + }
>> + }
>> +
>> md->mii_bus = mdiobus_alloc();
>> if (!md->mii_bus) {
>> dev_err(&pdev->dev, "mdiomux bus alloc failed\n");
>> - return -ENOMEM;
>> + rc = -ENOMEM;
>> + goto out;
>
> Hi Arun
>
> There is a devm_mdiobus_alloc() which could make the cleanup on error
> simple.
>
Should I do this as a separate patch ?
Thanks
Arun
>> }
>>
>> bus = md->mii_bus;
>> @@ -217,7 +250,7 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
>> rc = mdiobus_register(bus);
>> if (rc) {
>> dev_err(&pdev->dev, "mdiomux registration failed\n");
>> - goto out;
>> + goto out_alloc;
>> }
>>
>> platform_set_drvdata(pdev, md);
>> @@ -236,8 +269,11 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
>>
>> out_register:
>> mdiobus_unregister(bus);
>> -out:
>> +out_alloc:
>> mdiobus_free(bus);
>> +out:
>> + if (md->core_clk)
>> + clk_disable_unprepare(md->core_clk);
>> return rc;
>> }
>
> Andrew
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
