On Mon, Jul 30, 2018 at 8:30 AM, Keiji Hayashibara <hayashibara.keiji@xxxxxxxxxxxxx> wrote: > Hello Trent and Andy, >> > > + ckrat = roundup(ckrat, 2); >> > >> > ckrat += ckrat & 1; >> >> Either way, the compiler produces the same code: >> >> add r0, r0, #1 >> bic r0, r0, #1 >> >> I.e., ckrat = (ckrat + 1) & ~1, one "add" and one "and". >> >> Might as well use the macro so it's clear. There is also round_up(x,y), which I believe is intended to be used >> only with power of 2 values of y. > > I confirmed round_up() macro. > This macro is optimized to power of 2 argument, > and it matches to this case and clear. > > I will replace to round_up() macro. Good! -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
