HI Rob On 07/25/2018 07:29 AM, Rob Herring wrote: > On Thu, Jul 12, 2018 at 09:12:43PM +0000, Yixun Lan wrote: >> Document the MMC sub clock controller driver, the potential consumer >> of this driver is MMC or NAND. Also add three clock bindings IDs which >> provided by this driver. >> >> Signed-off-by: Yixun Lan <yixun.lan@xxxxxxxxxxx> >> --- >> .../bindings/clock/amlogic,mmc-clkc.txt | 31 +++++++++++++++++++ >> .../clock/amlogic,meson-mmc-clkc.h | 16 ++++++++++ >> 2 files changed, 47 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt >> create mode 100644 include/dt-bindings/clock/amlogic,meson-mmc-clkc.h > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Thanks for the review! There is a discussion about dropping "meson-" prefix in the compatible string[1] So, I will send another version with the new compatible name adjusted from "amlogic,meson-axg-mmc-clkc" to "amlogic,axg-mmc-clkc".. probably also rename the dt-bindings header file to amlogc,mmc-clkc.h [1] https://lkml.kernel.org/r/7hk1prmg4w.fsf@xxxxxxxxxxxx Yixun -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html