On Thu, Jul 26, 2018 at 5:12 PM, Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
>
>
> On 26.07.2018 13:09, Jassi Brar wrote:
>> On Thu, Jul 26, 2018 at 4:21 PM, Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
>>
>>>>
>>>>> +struct imx_mu_con_priv {
>>>>> + int irq;
>>>>> + unsigned int idx;
>>>>> + char *irq_desc;
>>>>>
>>>> Having char irq_desc[16]; seems simpler than free/kfree upon
>>>> each startup/shutdown. Simply use snprintf() in probe().
>>>
>>> Currently all known configurations use one or two channels. I don't see
>>> any sense to allocate all at the probe.
>>>
>> Just because only 2 out of 4 channels are being used, it doesn't make sense?
>>
>> What is the concern? "wasting" 16x2 bytes of memory? How many bytes,
>> LOC and execution time does kasprintf() waste?
>
> Startup or shutdown is not speed critical path in this driver, or do i
> miss some thing?
>
No they are not.
> Speed vs size is not valid argumentation here.
>
If the code looks cleaner and smaller and lesser expensive execution
wise, at least I see that as a valid enough argument.
But OK, if you insist. If someone sends a "cleanup" patch tomorrow, I
am going to thank and apply.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
