On Tue, Jul 24, 2018 at 11:18:13AM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2018-07-23 19:52, Krzysztof Kozlowski wrote: > > Hi All, > > > > Changes since v1 > > ================ > > 1. Add Tomasz's ack. > > 2. Reword description in patch 6/10. > > > > > > Tests > > ===== > > This is both request for comments and requests for tests. Only basic > > tests were done, including suspend to RAM on Odroid U3 (Exynos4412) > > with max7768 RTC wakeup. Please kindly test it with devices capable of > > suspending and resuming. I am mostly thinking about S5Pv210-based (Aria), > > Trats, Trats2 and TM2 (Exynos5433). Existing platforms should not be > > broken however changing external interrupt wakeup mask was not done > > on Exynos5433. > > Works fine on Exynos5433 TM2 with some additional patches related to > suspend/resume handling of the PMU. It handles only EINT0..EINT31 pins > for now. Exynos5433 has more external interrupt wakeup lines: EINT32-63 > located at banks GPF1[0..7], GPF2[0..3], GPF3[0..3], GPF4[0..7] and > GPF5[0..7]. They can be configured as wakeup sources in > EXYNOS5433_EINT_WAKEUP_MASK1 (0x062C) PMU register. Handling of them > can be added later when it will be really needed. > > Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> Thanks for comments and testing. Indeed support for Exynos5433 has to be improved. I would like to push 1-6 (which are needed for the rest) through current cycle so I applied them to samsung-pinctrl tree. Since anyway suspend to RAM is mostly broken nowadays... nothing more should pop up. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
