On Tue, Jul 24, 2018 at 10:37:51AM +0800, Chen-Yu Tsai wrote: > On Tue, Jul 24, 2018 at 10:28 AM, Icenowy Zheng <icenowy@xxxxxxx> wrote: > > > > > > 于 2018年7月24日 GMT+08:00 上午10:26:02, Chen-Yu Tsai <wens@xxxxxxxx> 写到: > >>On Tue, Jul 24, 2018 at 10:23 AM, Icenowy Zheng <icenowy@xxxxxxx> > >>wrote: > >>> > >>> > >>> 于 2018年7月24日 GMT+08:00 上午10:21:59, Chen-Yu Tsai <wens@xxxxxxxx> 写到: > >>>>On Tue, Jul 24, 2018 at 9:15 AM, Icenowy Zheng <icenowy@xxxxxxx> > >>wrote: > >>>>> The Pine H64 model A has a Wi-Fi module connector and the model B > >>has > >>>>an > >>>>> on-board RTL8723BS Wi-Fi module. > >>>>> > >>>>> Add support for them. For model A, as it's not defaultly present, > >>>>keep > >>>>> it disabled now. > >>>> > >>>>Nope. Pine64 actually has two WiFi/BT modules. And they require > >>>>different > >>>>device tree snippets for both the WiFi and BT side. This is better > >>>>resolved > >>>>with device tree overlays. > >>>> > >>>>I have both, though I've yet found time to work on them. > >>> > >>> I have also both. > >>> > >>> The skeleton here can get the Wi-Fi of both to work. > >> > >>Cool. Then I can put away my RTL module for now. :) > > > > P.S. SDIO is auto detectable, and for BCM chips, the OOB interrupt > > is only a bonus function and it can fall back to standard in-band > > interrupt (which doesn't need special binding, and is currently > > used by mainline r8723bs driver.) > > Correct. With BT you'll have serdev device nodes with different > compatibles. Then you'll have to resort to overlays, and you'd probably > end up adding WiFi OOB interrupt bits as well. > > So the question remaining is: should we enable the MMC part, along > with power sequencing and regulator supplies, by default? Thinking > more about it, I'm actually OK with it. The board connectors are > clearly marked as being for a WiFi+BT module. The whole space on > the board is surrounded by a box in silkscreen. Sorry for the > initial nack. > > Maxime, any thoughts? If there's a need for an overlay anyway, there's no real reason to enable it by default, especially if not everything is there. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
