Hi Rob, thanks for the review. I will integrate it in a v3. Regards, Marco On 18-07-16 11:55, Rob Herring wrote: > On Fri, Jul 13, 2018 at 02:50:01PM +0200, Marco Felsch wrote: > > This binding is used to keep the backward compatibility with the current > > dtb's [1]. The binding informs the driver that the unused switch regulators > > can be disabled. > > If it is not specified, the driver doesn't disable the switch regulators. > > > > [1] https://patchwork.kernel.org/patch/10490381/ > > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > > > --- > > Changes in V2: > > - add more information about the binding > > - rename binding and add vendor prefix > > > > .../devicetree/bindings/regulator/pfuze100.txt | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/regulator/pfuze100.txt b/Documentation/devicetree/bindings/regulator/pfuze100.txt > > index 672c939045ff..2c46b8d368db 100644 > > --- a/Documentation/devicetree/bindings/regulator/pfuze100.txt > > +++ b/Documentation/devicetree/bindings/regulator/pfuze100.txt > > @@ -4,6 +4,17 @@ Required properties: > > - compatible: "fsl,pfuze100", "fsl,pfuze200", "fsl,pfuze3000", "fsl,pfuze3001" > > - reg: I2C slave address > > > > +Optional properties: > > +- fsl,pfuze-support-disable: Boolean, if present disable all unused switch > > + regulators to save power consumption. Attention, till 4.18 these regulators > > You shouldn't have kernel version info in bindings. > > > + were always on without specifying "regulator-always-on". So be sure to mark > > + import regulators as "regulator-always-on" (e.g. DDR ref, DDR supply). If > > s/import/important/ > > > + not present, the switched regualtors are always on and can't be disabled. > > + This binding is a workaround to keep backward compatibility with old dtb's > > + which rely on the fact that the switched regulators are always on and don't > > + mark them explicit as "regulator-always-on". On new dtbs this property should > > + always be present. > > + > > Required child node: > > - regulators: This is the list of child nodes that specify the regulator > > initialization data for defined regulators. Please refer to below doc > > -- > > 2.18.0 > > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5082 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
