> > +Realtek SMI-based Switches > > +========================== > > + > > +The SMI "Simple Management Interface" is a two-wire protocol using > > At least for some other Realtek chips, the documentation I find says the > S stands for Serial. And Wikipedia says SMI is the same thing as MDIO. > > Just want to make sure we don't define GPIOs directly when there should > be a layer of abstraction like mdio-gpio. Hi Rob There was a bit of discussion about this with the RFC patches. The bit stream protocol used here is not that used by SMI in MDIO. It is something proprietary to Realtek. I don't expect we will be re-using the code with other vendors. The only real reason to abstract this out is if there happens to be other Realtek switches which uses the same SMI bitstream, but have completely different registers, meaning a separate DSA driver would be needed. The SMI code is well structured, so it should not be too hard to turn it into a library which drivers can share. So i personally don't see a problem with this. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html