On Fri, Feb 28, 2014 at 01:24:35PM +0200, Georgi Djakov wrote:
> This patch adds implementation for platform specific tuning in order to support
> HS200 bus speed mode on Qualcomm SDHCI controller.
>
> Signed-off-by: Asutosh Das <asutoshd@xxxxxxxxxxxxxx>
> Signed-off-by: Venkat Gopalakrishnan <venkatg@xxxxxxxxxxxxxx>
> Signed-off-by: Georgi Djakov <gdjakov@xxxxxxxxxx>
> ---
> drivers/mmc/host/sdhci-msm.c | 424 +++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 418 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index b4490a2..69f6887 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
[..]
> +int sdhci_msm_execute_tuning(struct sdhci_host *host, u32 opcode)
> +{
> + int tuning_seq_cnt = 3;
> + u8 phase, *data_buf, tuned_phases[16], tuned_phase_cnt = 0;
> + const u32 *tuning_block_pattern = tuning_block_64;
> + int size = sizeof(tuning_block_64); /* Pattern size in bytes */
> + int rc;
> + struct mmc_host *mmc = host->mmc;
> + struct mmc_ios ios = host->mmc->ios;
> +
> + /*
> + * Tuning is required for SDR104, HS200 and HS400 cards and
> + * if clock frequency is greater than 100MHz in these modes.
> + */
> + if (host->clock <= 100 * 1000 * 1000 ||
> + !((ios.timing == MMC_TIMING_MMC_HS200) ||
> + (ios.timing == MMC_TIMING_UHS_SDR104)))
> + return 0;
> +
> + if ((opcode == MMC_SEND_TUNING_BLOCK_HS200) &&
> + (mmc->ios.bus_width == MMC_BUS_WIDTH_8)) {
> + tuning_block_pattern = tuning_block_128;
> + size = sizeof(tuning_block_128);
> + }
> +
> + data_buf = kmalloc(size, GFP_KERNEL);
> + if (!data_buf)
> + return -ENOMEM;
> +
> +retry:
> + /* First of all reset the tuning block */
> + rc = msm_init_cm_dll(host);
> + if (rc)
> + goto out;
> +
> + phase = 0;
> + do {
> + struct mmc_command cmd = { 0 };
> + struct mmc_data data = { 0 };
> + struct mmc_request mrq = {
> + .cmd = &cmd,
> + .data = &data
> + };
> + struct scatterlist sg;
> +
> + /* Set the phase in delay line hw block */
> + rc = msm_config_cm_dll_phase(host, phase);
> + if (rc)
> + goto out;
> +
> + cmd.opcode = opcode;
> + cmd.flags = MMC_RSP_R1 | MMC_CMD_ADTC;
> +
> + data.blksz = size;
> + data.blocks = 1;
> + data.flags = MMC_DATA_READ;
> + data.timeout_ns = NSEC_PER_SEC; /* 1 second */
> +
> + data.sg = &sg;
> + data.sg_len = 1;
> + sg_init_one(&sg, data_buf, sizeof(data_buf));
> + memset(data_buf, 0, sizeof(data_buf));
> + mmc_wait_for_req(mmc, &mrq);
> +
> + if (!cmd.error && !data.error &&
> + !memcmp(data_buf, tuning_block_pattern, sizeof(data_buf))) {
This memcmp is broken, sizeof(data_buf) is likely not what you want,
maybe you want 'size'? Same thing for sg_init_one()/memset() above.
>From sparse:
drivers/mmc/host/sdhci-msm.c: In function â??sdhci_msm_execute_tuningâ??:
drivers/mmc/host/sdhci-msm.c:461:53: warning: argument to â??sizeofâ?? in â??memcmpâ?? call is the same expression as the first source; did you mean to provide an explicit length? [-Wsizeof-pointer-memaccess]
!memcmp(data_buf, tuning_block_pattern, sizeof(data_buf))) {
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
