On 13/07/2018 12:56:22+0300, Radu Pirea wrote: > > > On 07/10/2018 09:15 PM, Mark Brown wrote: > > On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote: > > > > This is mostly good, just a couple of small things: > > > > > +config SPI_AT91_USART > > > + tristate "Atmel USART Controller SPI driver" > > > + depends on HAS_DMA > > > + depends on (ARCH_AT91 || COMPILE_TEST) > > > + select MFD_AT91_USART > > > > Why is this selecting rather than depending on the MFD like we normally > > do? > > > > Hi Mark, > > If I add depends instead of select, current defconfigs will be broken and > the proper driver will not be selected. Like this, there is no required > change in any defconfig. Selecting the serial or spi driver from menuconfig > makes the MFD completely transparent. I would say that this is true for the USART part but the SPI part can use a depends on as it didn't exist before. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
