On Friday 28 February 2014 04:23 AM, Arnd Bergmann wrote: > On Thursday 27 February 2014 19:27:03 Santosh Shilimkar wrote: >> >> The of-dma.c is compiled out with !CONFIG_DMA_OF but the functions in >> the header are kept under CONFIG_OF. Move them under CONFIG_OF_DMA >> to avoid build errors with CONFIG_OFF && !CONFIG_DMA_OF >> >> Cc: Grant Likely <grant.likely@xxxxxxxxxx> >> Cc: Rob Herring <robh+dt@xxxxxxxxxx> >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> > > Sorry, but what is the problem you are seeing with this? > > CONFIG_DMA_OF is defined as 'OF && DMAENGINE', and this code > should only be called from drivers that depend on DMAENGINE. > > I'm not saying your patch is wrong, but you shouldn't need it > unless you do something very odd. > So for ARM 'allnoconfig' build we have CONFIG_OF enabled but CONFIG_DMA_OF disabled. With that the of-dma.c gets compiled out leaving the functions from of-dma.h undefined. I noticed this while adding couple of exports in of_dma.h I am not sure but we added couple of functions for dma-ranges and dma-coherent which gets called from generic code. In any case, the patch makes sense since the header and Makefile are not consistent. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
