On Fri, Jul 06, 2018 at 08:05:59AM +0100, Lee Jones wrote:
> On Thu, 05 Jul 2018, Dmitry Torokhov wrote:
>
> > On July 5, 2018 12:56:50 AM PDT, Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote:
> > >On Wed, Jul 04, 2018 at 06:57:39PM +0200, Enric Balletbo Serra wrote:
> > >> Missatge de Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> del dia dc.,
> > >4
> > >> de jul. 2018 a les 17:10:
> > >> >
> > >> > Hi Enric,
> > >> >
> > >> > On Tue, Jun 26, 2018 at 11:06:33AM +0200, Enric Balletbo Serra
> > >wrote:
> > >> > > > +static struct mfd_cell bd71837_mfd_cells[] = {
> > >> > > > + {
> > >> > > > + .name = "bd71837-clk",
> > >> > > > + }, {
> > >> > > > + .name = "bd718xx-pwrkey",
> > >> > > > + .resources = &irqs[0],
> > >> > > > + .num_resources = ARRAY_SIZE(irqs),
> > >> > > > + }, {
> > >> > > > + .name = "bd71837-pmic",
> > >> > > > + },
> > >> > > nit: no comma at the end
> > >> >
> > >> > Actually, trailing comma is preferred on structures/arrays without
> > >> > sentinels, because if one needs to add a new entry/new member, then
> > >in
> > >> > the diff there will have only one new line added, instead of one
> > >line
> > >> > being changed (adding now necessary comma) and one added.
> > >> >
> > >>
> > >> Many thanks for sharing your knowledge! That looks to me a good
> > >> reason.
> > >
> > >So in this specific ecample leaving the comma does not help. The
> > >opening
> > >brace for new array element would be added to same line where the comma
> > >is, right?
> >
> > Ah, yes, you are right. We usually have either:
> >
> > { /* element 1 */ },
> > { / *element 2 */ },
> > ...
> >
> > or:
> >
> > {
> > /* element 1 */
> > },
> > {
> > /* element 2 */
> > },
> >
> > but I do not think that it is codified in the CodingStyle.
>
> FWIW, my *strong* preference for single line entries in the
> aforementioned single line format. Then Dmitry's explanation rings
> true.
The reasoning given by Dmitry makes perfect sense. And to my eyes:
{
/* element 1 */
},
{
/* element 2 */
},
actually looks better than:
> {
/* element 1 */
}, {
/* element 2 */
},
So if first one is not enforced in order to minimize almost empty lines
- then I will try to be using the latter in the future. (In such cases
where element consists of more than one value).
Thanks for this little lesson =)
Br,
Matti Vaittinen
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
