Hi Matthias, On 2018년 07월 04일 08:46, Matthias Kaehlcke wrote: > Several governors use the user space limits df->min/max_freq to adjust > the target frequency. This is not necessary, since update_devfreq() > already takes care of this. Instead the governor can request the available > min/max frequency by setting the target frequency to DEVFREQ_MIN/MAX_FREQ > and let update_devfreq() take care of any adjustments. > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx> > --- > Changes in v5: > - none > > Changes in v4: > - added 'Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>' tag > > Changes in v3: > - none > > Changes in v2: > - squashed "PM / devfreq: Remove redundant frequency adjustment from governors" > and "PM / devfreq: governors: Return device frequency limits instead of user > limits" > - updated subject and commit message > - use DEVFREQ_MIN/MAX_FREQ instead of df->scaling_min/max_freq > --- > drivers/devfreq/governor.h | 3 +++ > drivers/devfreq/governor_performance.c | 5 +---- > drivers/devfreq/governor_powersave.c | 2 +- > drivers/devfreq/governor_simpleondemand.c | 12 +++--------- > drivers/devfreq/governor_userspace.c | 16 ++++------------ > 5 files changed, 12 insertions(+), 26 deletions(-) Actually, I preferred to use 'df->scaling_min/max_freq' instead of DEVFREQ_MIN/MAX_FREQ. But, DEVFREQ_MIN/MAX_FREQ is other way. So, Looks good to me. Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> [snip] -- Best Regards, Chanwoo Choi Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
