Re: [RFC PATCH 5/5] arm: dts: zynq: remove "zynq" prefix from compatible property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michal,

On Thu, Jun 28, 2018 at 2:42 AM Michal Simek <michal.simek@xxxxxxxxxx> wrote:
> zynq name here is correct which is saying that hardblock is going to be
> described. Without it it is suggesting that hardblock is not used and it
> is for example on zybo with microblaze.

In my opinion, the zynq name is just adding redundant information to
the "xlnx,zynq-7000" value.
Taking the Zybo board, the current compatible property is:
> compatible = "digilent,zynq-zybo", "xlnx,zynq-7000";

I'm proposing to change it to:
> compatible = "digilent,zybo", "xlnx,zynq-7000";
(I know I must keep the old value too,  I'm simplifying)

In the case of a Zybo board with a microblaze, the property could be:
> compatible = "digilent,zybo", "xlnx,microblaze";

That would allow to differentiate between zynq and microblaze.

I have no problem on dropping the patch if you like. There might be
something that I'm not seeing or a use case that I'm missing.


Thanks,

Luis Araneda.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux