On Fri 2018-06-29 14:26:00, Greg Kroah-Hartman wrote: > On Fri, Jun 29, 2018 at 11:46:07AM +0200, Pavel Machek wrote: > > > > > > Finally, note that documentation (including kerneldoc) remains to be > > > > written, but hopefully this will not hinder review given that the > > > > current interfaces are fairly self-describing. > > > > > > This all looks great. Thanks for doing this work and adding a new > > > subsystem for something that has been asked for for many years. > > > > > > All now merged in my tree, nice job! > > > > I don't think discussion was finished on this one. > > It looked done to me as there was only a single set of patches, with no > other working patches submitted from anyone else. Is "noone submitted patches on top" sufficient reason to apply the patch? > If this turns out to be a "bad" api, then we can deal with it then, but > for now let's try this out. Series uses /dev/gnss0 , without providing hardware abstraction, blocking place for proper gnss layer. Suggested fix is to to make it "/dev/gnssraw0". How do you propose to fix this after it is merged? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
