On Wed, Jun 27, 2018 at 02:00:11PM -0300, Fabio Estevam wrote: > On Wed, Jun 27, 2018 at 1:46 PM, Andrey Smirnov > <andrew.smirnov@xxxxxxxxx> wrote: > > > We are now starting to give Andrey Gusakov conflicting > > recommendations. For the sake of moving forward, can we agree that > > this and similar comments are relatively minor and defer to the > > maintainers to make a call which way to go? > > This way Andrey has a clear way on how to move forward with this set. > > The approach in this patched looked fine to me as well. > > Maybe we can have some feedback from Shawn? I'm overall fine with the approach as well. But I agree with Nikita's comment that having pinctrl definition and usage spread in different files makes reader's life harder. So I would suggest that we have the following properties in imx51-zii-rdu1.dts as well. pinctrl-names = "default"; pinctrl-0 = <&pinctrl_swi2c>; Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html