On Saturday, June 30, 2018 05:25 PM, Robert Jarzmik wrote:
Daniel Mack <daniel@xxxxxxxxxx> writes:
Call into mmc_of_parse() from pxamci_of_init(). As it needs a pointer to a
struct mmc_host, refactor the code a bit.
This allows all generic MMC properties to be set that are described in
Documentation/devicetree/bindings/mmc/mmc.txt.
Signed-off-by: Daniel Mack <daniel@xxxxxxxxxx>
I'm a bit worried about this one :
- mmc_of_init() will request the gpios from "cd-gpios" and "wp-gpios"
- pdata->gpio_card_detect will be used to request the same gpio in
pxa_mci_of_init()
So the gpio is acquired twice, isn't it ? Do you know this works by test proof,
and doesn't it make sense to remove the "pdata->gpio* =" statements from
pxamci_of_init() ?
Ah, yes. Thanks for spotting this, you're right! Will fix in v2!
Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
