On Thu, Jun 28, 2018 at 12:20 AM Rohit Kumar <rohitkr@xxxxxxxxxxxxxx> wrote: > > Thanks Rob for reviewing. > > > On 6/26/2018 12:47 AM, Rob Herring wrote: > > On Thu, Jun 21, 2018 at 04:23:18PM +0530, Rohit kumar wrote: > >> Add devicetree bindings documentation file for SDM845 sound card. > >> > >> Signed-off-by: Rohit kumar <rohitkr@xxxxxxxxxxxxxx> > >> --- > >> .../devicetree/bindings/sound/qcom,sdm845.txt | 82 ++++++++++++++++++++++ > >> 1 file changed, 82 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,sdm845.txt > >> > >> diff --git a/Documentation/devicetree/bindings/sound/qcom,sdm845.txt b/Documentation/devicetree/bindings/sound/qcom,sdm845.txt > >> new file mode 100644 > >> index 0000000..68feb08 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/sound/qcom,sdm845.txt > >> @@ -0,0 +1,82 @@ > >> +* Qualcomm Technologies Inc. SDM845 ASoC sound card driver > >> + > >> +This binding describes the SDM845 sound card, which uses qdsp for audio. > >> + > >> +- compatible: > >> + Usage: required > >> + Value type: <stringlist> > >> + Definition: must be "qcom,sdm845-sndcard" > >> + > >> +- qcom,audio-routing: > > Use just 'audio-routing'. > > This is same which is being followed in apq8096 machine driver. As all > qcom machine drivers will > mostly follow the same design, Vinod asked to pull out the APIs in > common file - https://patchwork.kernel.org/patch/10479625/ . > Same is for qcom,model. I will add missing documentation for it in the > next patchset. Yes, I know. There are lots of <vendor>,model and others, and I'm asking folks to drop the vendor prefix. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html