Hi Sebastian, On 28-06-18, 13:59, Sebastian Reichel wrote: > On Wed, Jun 27, 2018 at 05:22:57PM +0530, Vinod Koul wrote: > > Add support Qualcomm PM8xxx PON which is responsible for reboot > > mode support. > > > > Co-developed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > > --- > > drivers/power/reset/Kconfig | 8 ++++ > > drivers/power/reset/Makefile | 1 + > > drivers/power/reset/qcom-pon.c | 91 ++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 100 insertions(+) > > create mode 100644 drivers/power/reset/qcom-pon.c > > > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > > index df58fc878b3e..1572b2d3ad3d 100644 > > --- a/drivers/power/reset/Kconfig > > +++ b/drivers/power/reset/Kconfig > > @@ -104,6 +104,14 @@ config POWER_RESET_MSM > > help > > Power off and restart support for Qualcomm boards. > > > > +config POWER_RESET_QCOM_PON > > + bool "Qualcomm power-on driver" > > tristate? Hmmm I dont think there is a reason for this not being a module, though looking at reset driver, bunch of them seem to be inbuilt only. Bjorn, do you think we can be module or only inbuilt? > > Otherwise driver looks fine to me. Thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html