On Thu, Jun 28, 2018 at 10:52:17AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Thu, Jun 28, 2018 at 10:48 AM Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > On Wed, Jun 27, 2018 at 05:45:34PM +0100, Kieran Bingham wrote:
> > > On 27/06/18 17:40, Geert Uytterhoeven wrote:
> > > > On Wed, Jun 27, 2018 at 5:10 PM Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > > >> On Tue, Jun 26, 2018 at 01:57:47PM -0600, Rob Herring wrote:
> > > >>> On Thu, Jun 14, 2018 at 03:48:08PM +0200, Geert Uytterhoeven wrote:
> > > >>>> With recent dtc and W=1:
> > > >>>>
> > > >>>> ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
> > > >>>> ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"
> > > >>>>
> > > >>>> Unit addresses are always hexadecimal (without prefix), while the bases
> > > >>>> of reg property values depend on their prefixes.
> > > >>>>
> > > >>>> Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
> > > >>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > > >>>> ---
> > > >>>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
> > > >>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >>>
> > > >>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > > >>
> > > >> Geert, shall I apply this?
> > > >
> > > > I'd say yes. Thanks!
> > >
> > > I'm happy to throw an
> > >
> > > Acked-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> > >
> > > on the patch - but I had a pending question regarding the reg = <10> part.
> > >
> > > Shouldn't the reg become hex "reg = <0xa>" to be consistent?
> > >
> > > Either way - if there's precedent - take that route and I'm happy.
> >
> > Consistency seems good to me, Geert?
>
> Typically we use decimal for "small" and hex for "large" numbers.
> So far this was mostly relevant for the size parts of "reg"
> properties, as the address
> parts are usually large (if part of the main memory space).
>
> These are different, as they are not memory-mapped addresses.
> If you want to see 0xa and 0xb in the reg properties, I can respin.
I'll take this as is. We can decide how we want to address this,
in a consistent manner, without too many puns, later.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
