Hi, On Thu, Jun 28, 2018 at 09:55:40AM +0200, Daniel Mack wrote: > The w1 slave device used by this driver now has a of_node in case it > was matched against a devicetree sub-node of the bus master. This can > now be passed down to the power supply core which will parse more > properties from the node, such as 'power-supplies'. > > Signed-off-by: Daniel Mack <daniel@xxxxxxxxxx> > --- Thanks for the patch series. Having proper DT support is a nice addition. But instead of extending the platform device hack, please merge the w1 driver into ds2760_battery.c as it happened to the bq27000 driver already. The intermediate platform device is completly useless and only makes things more complicated. Basically move all code from w1_ds2760.c into ds2760_battery.c, drop some EXPORT_SYMBOL and make functions static instead. Then move content from probe/remove function into add_slave/remove_slave callbacks and drop all platform device things. -- Sebastian
Attachment:
signature.asc
Description: PGP signature
