On Thu, Jun 21, 2018 at 08:49:41PM +0200, Linus Walleij wrote:
> The TPO TPG110 bindings were using the DPI bindings (popular
> in the fbdev subsystem) but this misses the finer points
> learned in the DRM subsystem.
>
> We need to augment the bindings for proper DRM integration:
> the timings are expressed by the hardware, not put into the
> device tree.
>
> Old device trees with the DPI info will continue to work,
> but no known deployments exist.
>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> .../bindings/display/panel/tpo,tpg110.txt | 34 ++++++++-----------
> 1 file changed, 14 insertions(+), 20 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt
> index f5e3c6f2095a..0e918076d55e 100644
> --- a/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt
> +++ b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt
> @@ -1,26 +1,32 @@
> TPO TPG110 Panel
> ================
>
> -This binding builds on the DPI bindings, adding a few properties
> -as a superset of a DPI. See panel-dpi.txt for the required DPI
> -bindings.
> +This panel driver can driver a variety of panels. It requires
s/can driver/can drive/
Though what a driver supports is irrelevant to the binding...
If you remove timings, how does it drive a variety of panels? Just by
compatible? That would mean "tpo,tpg110" alone is not valid nor useful
as a fallback.
> +a few GPIO lines for control of its reset line and custom serial
> +protocol.
>
> Required properties:
> -- compatible : "tpo,tpg110"
> +- compatible : one of:
> + "ste,nomadik-nhk15-display", "tpo,tpg110"
> + "tpo,tpg110"
> - grestb-gpios : panel reset GPIO
> - scen-gpios : serial control enable GPIO
> - scl-gpios : serial control clock line GPIO
> - sda-gpios : serial control data line GPIO
I2C? That should be done differently...
> +- width-mm : see display/panel/panel-common.txt
> +- height-mm : see display/panel/panel-common.txt
>
> -Required nodes:
> -- Video port for DPI input, see panel-dpi.txt
> -- Panel timing for DPI setup, see panel-dpi.txt
> +The device node can contain one 'port' child node with one child
> +'endpoint' node, according to the bindings defined in
> +media/video-interfaces.txt. This node should describe panel's video bus.
>
> Example
> -------
>
> panel {
> - compatible = "tpo,tpg110", "panel-dpi";
> + compatible = "tpo,tpg110";
> + width-mm = <116>;
> + height-mm = <87>;
> grestb-gpios = <&stmpe_gpio44 5 GPIO_ACTIVE_LOW>;
> scen-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>;
> scl-gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>;
> @@ -32,16 +38,4 @@ panel {
> remote-endpoint = <&nomadik_clcd_pads>;
> };
> };
> -
> - panel-timing {
> - clock-frequency = <33200000>;
> - hactive = <800>;
> - hback-porch = <216>;
> - hfront-porch = <40>;
> - hsync-len = <1>;
> - vactive = <480>;
> - vback-porch = <35>;
> - vfront-porch = <10>;
> - vsync-len = <1>;
> - };
> };
> --
> 2.17.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
