Anson Huang Best Regards! > -----Original Message----- > From: Fabio Estevam [mailto:festevam@xxxxxxxxx] > Sent: Wednesday, June 27, 2018 9:21 AM > To: Anson Huang <anson.huang@xxxxxxx> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer > <s.hauer@xxxxxxxxxxxxxx>; Sascha Hauer <kernel@xxxxxxxxxxxxxx>; Fabio > Estevam <fabio.estevam@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; > Mark Rutland <mark.rutland@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; open list:OPEN FIRMWARE AND > FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; > linux-kernel <linux-kernel@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH] ARM: dts: make pfuze switch always-on for imx platforms > > On Tue, Jun 26, 2018 at 3:08 AM, Anson Huang <Anson.Huang@xxxxxxx> > wrote: > > commit (5fe156f regulator: pfuze100: add enable/disable for switch) > > will cause those unreferenced switches being > > Nit: The proper way to reference a commit is: > > commit 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch") > > 12 char for the commit ID and the commit name inside (" "). > > > turned off if "regulator-always-on" is NOT present, as pfuze switches > > are normally used by critical modules which must be always ON or > > shared by many peripherals which do NOT implement power domain > > control, so just make sure all switches always ON to avoid any system > > issue caused by unexpectedly turning off switches. > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx> Thanks, will improve it and also the other patch for imx6sll. Anson. ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
