Re: [PATCH] dt-bindings: sram: Add 'clocks' as an optional property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fabio,

On 06/23/2018 06:22 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxx>
> 
> Some SoCs (like i.MX53) need to specify the SRAM clock in the
> device tree via the clocks property.
> 
> Add an entry to the optional property section.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
> ---
>  Documentation/devicetree/bindings/sram/sram.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/sram/sram.txt b/Documentation/devicetree/bindings/sram/sram.txt
> index 267da44..05689c1 100644
> --- a/Documentation/devicetree/bindings/sram/sram.txt
> +++ b/Documentation/devicetree/bindings/sram/sram.txt
> @@ -50,6 +50,7 @@ Optional properties in the area nodes:
>  		 manipulation of the page attributes.
>  - label : the name for the reserved partition, if omitted, the label
>            is taken from the node name excluding the unit address.
> +- clocks: the clock specifier that controls the SRAM clock.

just a nitpicking, all other property descriptions have a space before
a colon.

Also probably it makes sense to correct and pluralize "the clock specifier"
into a widely used form of "a list of phandle and clock specifier pairs",
while currently the driver does not support multiple clocks, it may be
extended in the future.

With that fixed,

Reviewed-by: Vladimir Zapolskiy <vz@xxxxxxxxx>

--
Best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux