On 24-06-18, 23:11, Bjorn Andersson wrote: > > struct pm8941_pwrkey { > > struct device *dev; > > @@ -52,6 +57,9 @@ struct pm8941_pwrkey { > > > > unsigned int revision; > > struct notifier_block reboot_notifier; > > + > > + unsigned int code; > > I still would like this to be a u32, as you pass it by reference to a > function taking a u32. somehow missed this one, will update and send v3 with your ACK > Apart from that, this looks good and you have my: > > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html