On Sun, 24 Jun 2018 21:22:28 +0200 Stefan Agner <stefan@xxxxxxxx> wrote: > + > +static int tegra_nand_remove(struct platform_device *pdev) > +{ > + struct tegra_nand_controller *ctrl = platform_get_drvdata(pdev); > + > + nand_release(nand_to_mtd(ctrl->chip)); I still see nand_release() being used here. As I said in my review of v6, it's not safe. Please use mtd_device_unregister() + nand_cleanup() instead, and check the return code of mtd_device_unregister(). With this addressed Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx> > + > + clk_disable_unprepare(ctrl->clk); > + > + return 0; > +} > + -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html