On 22 June 2018 at 12:39, Andrzej Hajda <a.hajda@xxxxxxxxxxx> wrote: > On 20.06.2018 20:28, Krzysztof Kozlowski wrote: >> On Tue, May 15, 2018 at 02:12:39PM +0200, Andrzej Hajda wrote: >>> OF graph describes USB data lanes between USB-PHY and respective MUIC. >>> Since graph is present and DWC driver can use it to get extcon, obsolete >>> extcon property can be removed. >>> >>> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx> >>> --- >>> .../dts/exynos/exynos5433-tm2-common.dtsi | 19 ++++++++++++++++++- >>> 1 file changed, 18 insertions(+), 1 deletion(-) >> dtc W=1 now complains with: >> === >> Warning (graph_child_address): >> /soc/hsi2c@14d90000/max77843@66/max77843-muic/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary >> === >> >> Do you plan to add more ports soon? > > There could be a link between UART and MUIC, it could be beneficial for > the platform - there is no point to feed UART with data when UART output > is muxed-out by MUIC. > So I plan to investigate it but this is not on my short list :) > Alternatively one can create graphs without using it atm. In that case could you remove here the address/size-cells to fix the warning? I see that code uses -1 in of_graph_get_remote_node() so it should not depend on the reg number. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
