Re: [PATCH v3 2/5] leds: lt3593: merge functions and clean up code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



HI Jacek,

On Thursday, June 21, 2018 09:23 PM, Jacek Anaszewski wrote:
You switched to using kcalloc, but apparently without compile-testing
it:

drivers/leds/leds-lt3593.c: In function ‘lt3593_led_probe_pdata’:
drivers/leds/leds-lt3593.c:88:13: error: too few arguments to function
‘devm_kcalloc’
    led_data = devm_kcalloc(dev, sizeof(*led_data), GFP_KERNEL);

How embarrassing. I didn't mean to switch to kcalloc as I'm not allocation an array anymore. I forgot to stage a hunk when rebasing though. Oh well.

Once you'll be resending the patch set please also remove
empty line at the end of DT bindings.

Also you could think of switching to using SPDX license identifier
at the occasion of updating the email address.

Will do. Sorry for the trouble. I'm sure v4 will be good finally :)



Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux