On Fri, Jun 15, 2018 at 4:39 AM, Icenowy Zheng <icenowy@xxxxxxx> wrote: > > > 于 2018年6月15日 GMT+08:00 上午1:27:21, "Jernej Škrabec" <jernej.skrabec@xxxxxxxxx> 写到: >>Dne četrtek, 14. junij 2018 ob 19:09:56 CEST je Jagan Teki napisal(a): >>> On Thu, Jun 14, 2018 at 9:05 PM, Chen-Yu Tsai <wens@xxxxxxxx> wrote: >>> > From: Icenowy Zheng <icenowy@xxxxxxx> >>> > >>> > Allwinner A64 has a SRAM controller, and in the device tree >>currently >>> > we have a syscon node to enable EMAC driver to access the EMAC >>clock >>> > register. As SRAM controller driver can now export regmap for this >>> > register, replace the syscon node to the SRAM controller device >>node, >>> > and let EMAC driver to acquire its EMAC clock regmap. >>> > >>> > Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx> >>> > [wens@xxxxxxxx: Updated compatible string] >>> > Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx> >>> > --- >>> > >>> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19 >>+++++++++++++++++-- >>> > 1 file changed, 17 insertions(+), 2 deletions(-) >>> > >>> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>> > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index >>> > 1b2ef28c42bd..87968dafe1dc 100644 >>> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>> > @@ -169,9 +169,24 @@ >>> > >>> > ranges; >>> > >>> > syscon: syscon@1c00000 { >>> > >>> > - compatible = >>> > "allwinner,sun50i-a64-system-controller", - >> >>> > "syscon"; >>> > + compatible = >>> > "allwinner,sun50i-a64-system-control"; >>> > >>> > reg = <0x01c00000 0x1000>; >>> > >>> > + #address-cells = <1>; >>> > + #size-cells = <1>; >>> > + ranges; >>> > + >>> > + sram_c: sram@18000 { >>> > + compatible = "mmio-sram"; >>> > + reg = <0x00018000 0x28000>; >>> > + #address-cells = <1>; >>> > + #size-cells = <1>; >>> > + ranges = <0 0x00018000 0x28000>; >>> > + >>> > + de2_sram: sram-section@0 { >>> >>> So, this can attach to display-engine node through allwinner,sram and >>> add support to claim the sram on sun4i/sun4i_drv.c, correct? >> >>Actually, it has to be added to display_clocks node and claimed in >>drivers/ >>clk/sunxi-ng/ccu-sun8i-de2.c > > Sorry it's old practice. > > My new way is to add a bus driver which claims the SRAM. Are you pointing this driver[1] ? if yes do we have recent version patches for these changes so-that I can import. [1] https://patchwork.kernel.org/patch/10290399/ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html