On Wed, Jun 13, 2018 at 06:03:21PM +0200, Jernej Škrabec wrote: > > > +Required properties: > > > + - compatible: value must be one of: > > > + * allwinner,sun8i-r40-tcon-top > > > + - reg: base address and size of the memory-mapped region. > > > + - clocks: phandle to the clocks feeding the TCON TOP > > > + * bus: TCON TOP interface clock > > > + - clock-names: clock name mentioned above > > > + - resets: phandle to the reset line driving the DRC > > > > s/DRC/TCON TOP/ ? > > Yes, copy & paste issue > > > > > > + * rst: TCON TOP reset line > > > > Remaining consistent with the clock name would be great > > You mean "ahb"? I noticed that most other nodes with reset lines don't have a > name associated. Maybe I could just drop it and use first specified reset? It's called bus in the binding, but yes. And yeah, we can drop the name as well. > > > > > + - reset-names: reset name mentioned above > > > + - #clock-cells : must contain 1 > > > > An example would be nice here > > You mean node example? with ports? In the past, Rob was against examples > unless really necessary. Node from R40 DTSI can serve as an example. Ok. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
