Hi! 2014-02-26 1:46 GMT+01:00 Sebastian Reichel <sre@xxxxxxxxxx>: > Hi, > > This is PATCHv1 for converting rx51-battery to the IIO API > and adding DT support. The patchset compiles and has been > tested on my Nokia N900. It depends on another patchset > converting twl4030-madc to the IIO API: > > https://lkml.org/lkml/2014/2/25/627 > > -- Sebastian > > Sebastian Reichel (2): > rx51_battery: convert to iio consumer > Documentation: DT: Document rx51-battery binding > > .../devicetree/bindings/power/rx51-battery.txt | 25 ++++++++ > drivers/power/rx51_battery.c | 68 ++++++++++++++-------- > 2 files changed, 70 insertions(+), 23 deletions(-) > create mode 100644 Documentation/devicetree/bindings/power/rx51-battery.txt > > -- > 1.8.5.3 > Thanks for patch! I would like to ask other kernel developers what do you think about moving ADC channel numbers from rx51_battery.ko driver code to DT. Driver rx51_battery.ko is platform specific for Nokia RX-51 (N900) so it is usefull only for this one device. Before this patch all driver data (look-up tables, adc channel numbers, etc...) were in driver code. Now after this patch adc channel numbers were moved to DT. What do you think? It is better to have all data in one place (driver code) or some in DT and some in driver code? For me it does not make sense to move these numbers to DT, because driver is rx51 device specific and chaning it in DT does not make sense. And I think it is better to have add driver data in one place and not in two... Sebastian already wrote me that this is normal to have numbers in DT and other code in driver. But I think that driver which can be used only in one device (so specified only in one DT file) does not need to have configuration (via DT or board files). Or do you think that driver specified only for one device needs to have ADC numbers configuration via DT? -- Pali Rohár pali.rohar@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
