Re: [PATCH v1 2/2] hwmon: npcm-pwm: add NPCM7xx PWM driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tomer,

I love your patch! Perhaps something to improve:

[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Tomer-Maimon/dt-binding-hwmon-Add-NPCM7xx-PWM-documentation/20180531-034040
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: i386-randconfig-x079-06101602 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:7:0,
                    from include/linux/kernel.h:14,
                    from include/linux/list.h:9,
                    from include/linux/module.h:9,
                    from drivers//hwmon/npcm7xx-pwm.c:4:
   drivers//hwmon/npcm7xx-pwm.c: In function 'npcm7xx_pwm_probe':
>> include/linux/kern_levels.h:5:18: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH'
    #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
                       ^~~~~~~~
   include/linux/printk.h:339:9: note: in expansion of macro 'KERN_DEBUG'
     printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~~
   drivers//hwmon/npcm7xx-pwm.c:276:3: note: in expansion of macro 'pr_debug'
      pr_debug("pwm%d base is 0x%08X, res.start 0x%08X , size 0x%08X\n",
      ^~~~~~~~
   drivers//hwmon/npcm7xx-pwm.c:276:50: note: format string is defined here
      pr_debug("pwm%d base is 0x%08X, res.start 0x%08X , size 0x%08X\n",
                                                  ~~~^
                                                  %08llX
   In file included from include/linux/printk.h:7:0,
                    from include/linux/kernel.h:14,
                    from include/linux/list.h:9,
                    from include/linux/module.h:9,
                    from drivers//hwmon/npcm7xx-pwm.c:4:
   include/linux/kern_levels.h:5:18: warning: format '%X' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH'
    #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
                       ^~~~~~~~
   include/linux/printk.h:339:9: note: in expansion of macro 'KERN_DEBUG'
     printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~~
   drivers//hwmon/npcm7xx-pwm.c:276:3: note: in expansion of macro 'pr_debug'
      pr_debug("pwm%d base is 0x%08X, res.start 0x%08X , size 0x%08X\n",
      ^~~~~~~~
   drivers//hwmon/npcm7xx-pwm.c:276:64: note: format string is defined here
      pr_debug("pwm%d base is 0x%08X, res.start 0x%08X , size 0x%08X\n",
                                                                ~~~^
                                                                %08llX
--
   In file included from include/linux/printk.h:7:0,
                    from include/linux/kernel.h:14,
                    from include/linux/list.h:9,
                    from include/linux/module.h:9,
                    from drivers/hwmon/npcm7xx-pwm.c:4:
   drivers/hwmon/npcm7xx-pwm.c: In function 'npcm7xx_pwm_probe':
>> include/linux/kern_levels.h:5:18: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH'
    #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
                       ^~~~~~~~
   include/linux/printk.h:339:9: note: in expansion of macro 'KERN_DEBUG'
     printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~~
   drivers/hwmon/npcm7xx-pwm.c:276:3: note: in expansion of macro 'pr_debug'
      pr_debug("pwm%d base is 0x%08X, res.start 0x%08X , size 0x%08X\n",
      ^~~~~~~~
   drivers/hwmon/npcm7xx-pwm.c:276:50: note: format string is defined here
      pr_debug("pwm%d base is 0x%08X, res.start 0x%08X , size 0x%08X\n",
                                                  ~~~^
                                                  %08llX
   In file included from include/linux/printk.h:7:0,
                    from include/linux/kernel.h:14,
                    from include/linux/list.h:9,
                    from include/linux/module.h:9,
                    from drivers/hwmon/npcm7xx-pwm.c:4:
   include/linux/kern_levels.h:5:18: warning: format '%X' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH'
    #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
                       ^~~~~~~~
   include/linux/printk.h:339:9: note: in expansion of macro 'KERN_DEBUG'
     printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
            ^~~~~~~~~~
   drivers/hwmon/npcm7xx-pwm.c:276:3: note: in expansion of macro 'pr_debug'
      pr_debug("pwm%d base is 0x%08X, res.start 0x%08X , size 0x%08X\n",
      ^~~~~~~~
   drivers/hwmon/npcm7xx-pwm.c:276:64: note: format string is defined here
      pr_debug("pwm%d base is 0x%08X, res.start 0x%08X , size 0x%08X\n",
                                                                ~~~^
                                                                %08llX

vim +5 include/linux/kern_levels.h

314ba352 Joe Perches 2012-07-30  4  
04d2c8c8 Joe Perches 2012-07-30 @5  #define KERN_SOH	"\001"		/* ASCII Start Of Header */
04d2c8c8 Joe Perches 2012-07-30  6  #define KERN_SOH_ASCII	'\001'
04d2c8c8 Joe Perches 2012-07-30  7  

:::::: The code at line 5 was first introduced by commit
:::::: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for KERN_<LEVEL> to a 2 byte pattern

:::::: TO: Joe Perches <joe@xxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux