On Fri, 1 Jun 2018 00:16:35 +0200 Stefan Agner <stefan@xxxxxxxx> wrote: > + > +static const struct of_device_id tegra_nand_of_match[] = { > + { .compatible = "nvidia,tegra20-nand" }, > + { /* sentinel */ } > +}; > + > +static struct platform_driver tegra_nand_driver = { > + .driver = { > + .name = "tegra-nand", > + .of_match_table = tegra_nand_of_match, > + }, > + .probe = tegra_nand_probe, > + .remove = tegra_nand_remove, > +}; > +module_platform_driver(tegra_nand_driver); > + > +MODULE_DESCRIPTION("NVIDIA Tegra NAND driver"); > +MODULE_AUTHOR("Thierry Reding <thierry.reding@xxxxxxxxxx>"); > +MODULE_AUTHOR("Lucas Stach <dev@xxxxxxxxxx>"); > +MODULE_AUTHOR("Stefan Agner <stefan@xxxxxxxx>"); > +MODULE_LICENSE("GPL v2"); > +MODULE_DEVICE_TABLE(of, tegra_nand_of_match); Just a nitpick: can you move this MODULE_DEVICE_TABLE() just after the tegra_nand_of_match declaration? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html