Hi Geert, On Friday, 8 June 2018 12:29:29 EEST Geert Uytterhoeven wrote: > On Thu, Apr 26, 2018 at 11:11 PM, Laurent Pinchart wrote: > > On Thursday, 26 April 2018 19:53:40 EEST Kieran Bingham wrote: > >> The r8a77965 has 4 VSP instances. > >> > >> Based on a similar patch of the R8A7796 device tree > >> by Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>. > >> > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > >> [Kieran: Rebased to top of tree, fixed sort orders] > >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > >> --- > >> > >> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 44 +++++++++++++++++++++++ > >> 1 file changed, 44 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > >> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index > >> 1f44ed7c1b1c..e92e6b03333a 100644 > >> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > >> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > >> @@ -1025,6 +1047,17 @@ > >> resets = <&cpg 611>; > >> }; > >> > >> + vspd0: vsp@fea20000 { > >> + compatible = "renesas,vsp2"; > >> + reg = <0 0xfea20000 0 0x4000>; > > > > RFP2 has a CLUT so the register range needs to be extended. I'd recommend > > covering the entire space (0x8000) even if no LUT or CLU module is > > present. > > Even on V3H/V3M, which have some part of the CLUT, and could do > with 0x5000? > > Note that this makes it overlap with fcpvd0 on all R-Car Gen3 SoCs, > as mentioned by Simon on IRC. My bad :-/ I'll submit fixes shortly. > >> + interrupts = <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>; > >> + clocks = <&cpg CPG_MOD 623>; > >> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; > >> + resets = <&cpg 623>; > >> + > >> + renesas,fcp = <&fcpvd0>; > >> + }; > >> + > >> fcpvd0: fcp@fea27000 { > >> compatible = "renesas,fcpv"; > >> reg = <0 0xfea27000 0 0x200>; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html