Re: [PATCH v2 1/2] cpufreq: imx6q/thermal: imx: register cooling device depending on OF

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bastian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on soc-thermal/next]
[also build test ERROR on v4.17 next-20180607]
[cannot apply to shawnguo/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Bastian-Stender/cpufreq-imx6q-thermal-imx-register-cooling-device-depending-on-OF/20180608-134429
base:   https://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git next
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All error/warnings (new ones prefixed by >>):

   drivers//cpufreq/imx6q-cpufreq.c: In function 'imx6q_cpufreq_ready':
>> drivers//cpufreq/imx6q-cpufreq.c:208:10: error: implicit declaration of function 'of_cpufreq_power_cooling_register'; did you mean 'of_cpufreq_cooling_register'? [-Werror=implicit-function-declaration]
      cdev = of_cpufreq_power_cooling_register(np, policy,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             of_cpufreq_cooling_register
>> drivers//cpufreq/imx6q-cpufreq.c:208:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      cdev = of_cpufreq_power_cooling_register(np, policy,
           ^
   cc1: some warnings being treated as errors

vim +208 drivers//cpufreq/imx6q-cpufreq.c

   195	
   196	static void imx6q_cpufreq_ready(struct cpufreq_policy *policy)
   197	{
   198		struct device_node *np = of_node_get(cpu_dev->of_node);
   199		u32 capacitance = 0;
   200	
   201		if (WARN_ON(!np))
   202			return;
   203	
   204		if (of_find_property(np, "#cooling-cells", NULL)) {
   205			of_property_read_u32(np, "dynamic-power-coefficient",
   206					     &capacitance);
   207	
 > 208			cdev = of_cpufreq_power_cooling_register(np, policy,
   209								 capacitance, NULL);
   210	
   211			if (IS_ERR(cdev)) {
   212				dev_err(cpu_dev,
   213					"running cpufreq without cooling device: %ld\n",
   214					PTR_ERR(cdev));
   215	
   216				cdev = NULL;
   217			}
   218		}
   219	
   220		of_node_put(np);
   221	}
   222	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux