On 18-06-06 10:06 AM, Clément Péron wrote:
Hi Scott, Florian,
On Wed, 6 Jun 2018 at 18:47, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
On 06/06/201 8 09:03 AM, Scott Branden wrote:
Hi Clement,
On 18-06-06 02:34 AM, Clément Péron wrote:
From: Clément Peron <clement.peron@xxxxxxxxxxxx>
There is a HWRNG in Broadcom Cygnus SoC, so enable it.
Signed-off-by: Clément Peron <clement.peron@xxxxxxxxxxxx>
Thanks for upstreaming some missing Cygnus components.
But, the problem is the tarball release from Broadcom you are extracting
these changes from does not contain git history; so, you are missing the
original authors and signed-off's.
I checked our internal git repository and for this commit the author is:
Mohamed Ismail Abdul Packir Mohamed <mohamed-ismail.abdul@xxxxxxxxxxxx>
Please adjust author and signed-off appropriately. If there are other
changes you are extracting from the source tarballs you have please
contact me so we can construct patch appropriately.
If you want the original author's Signed-off-by to be preserved, why
don't you extract it from your internal git tree and submit the patch on
Mohamed's behalf?
AFAICT what Clement is doing here is permissible given the Linux
developer certificate of origin though I am not a lawyer of course.
--
Florian
Totally not my goal to steal the author and agree to keep track of the
original author
as soon as it's possible. I didn't though it was important for this
patch as the same
code is available in the dt-bindings documentation.
Actually there are still some buggy components like DSA (Arun proposed
a patch this morning)
the PWM (config and delay aren't correct) and I2C. These are mainlined
but can't be used
and need a minimal effort to correctly work on Cygnus.
We have internal versions of most everything. It's a matter of getting
people to push the appropriate patches out for upstream version to work.
Please contact the bcm-kernel-feedback list with issues and we can work
through common solution (or, likely already have a solution just not
upstreamed).
Also there are some important components like USB Phy or Mailbox that
were proposed and
almost made it, but just need a small modification to be accepted.
Again - we may have internal solution already. Yes, mailbox was
submitted upstream a long time ago and I think got stalled being
accepted upstream. We can work through upstream solution by starting
with sending to bcm-kernel-feedback-list to discuss details.
My idea was just to submit small patches that are trivial to review.
In order to avoid keeping
lots of patches in our kernel and also have something functional when
building a mainline kernel.
I understand the difficulty you would have if you're trying to work with
a different kernel version in our release. If you send me a list
directly of the drivers you use in Cygnus that will help me get those
changes prioritized to be pushed upstream. And/or we can work together
on that.
Regards,
Clement
Thanks,
Scott
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
