Hi Dennis, On mar., juin 05 2018, Dennis Gilmore <dennis@xxxxxxxx> wrote: > The helios4 is a Armada388 based nas board designed by SolidRun and > based on their SOM. It is sold by kobol.io the dts file came from > https://raw.githubusercontent.com/armbian/build/master/patch/kernel/mvebu-default/95-helios4-device-tree.patch > I added a SPDX license line to match the clearfog it says it was based > on and a compatible line for "kobol,helios4" This patch looks good, I have only two remarks for now. > + usb3_phy: usb3-phy { > + compatible = "usb-nop-xceiv"; > + //vbus-regulator = <®_5p0v_usb>; Why did you comment this line? What about removing it, if you don't need it? [...] > + > + usb@58000 { > + //vcc-supply = <®_5p0v_usb>; Same here > + usb-phy = <&usb2_phy>; > + status = "okay"; > + }; > + Gregory -- Gregory Clement, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
