Hi Boris,
I became interested after reading the cover letter...
On Fri, Jun 1, 2018 at 3:13 PM, Boris Brezillon
<boris.brezillon@xxxxxxxxxxx> wrote:
> Add bindings for SPI NAND chips.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>
Thanks for your patch!
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/spi-nand.txt
> @@ -0,0 +1,27 @@
> +SPI NAND flash
> +
> +Required properties:
> +- compatible: should be "spi-nand"
> +- reg: should encode the chip-select line used to access the NAND chip
> +
> +Optional properties
> +- spi-max-frequency: maximum frequency of the SPI bus the chip can operate at.
> + This should encode board limitations (i.e. max freq can't
> + be achieved due to crosstalk on IO lines).
> + When unspecified, the driver assumes the chip can run at
> + the max frequency defined in the spec (information
> + extracted chip detection time).
This is a standard property according to
Documentation/devicetree/bindings/spi/spi-bus.txt. Can't you just refer
to that file, or just omit it, as it applies to all SPI slaves anyway?
> +- spi-tx-bus-width: The bus width (number of data wires) that is used for MOSI.
> + Only encodes the board constraints (i.e. when not all IO
> + signals are routed on the board). Device constraints are
> + extracted when detecting the chip, and controller
> + constraints are exposed by the SPI mem controller. If this
> + property is missing that means no constraint at the board
> + level.
> +- spi-rx-bus-width: The bus width (number of data wires) that is used for MISO.
> + Only encodes the board constraints (i.e. when not all IO
> + signals are routed on the board). Device constraints are
> + extracted when detecting the chip, and controller
> + constraints are exposed by the SPI mem controller. If this
> + property is missing that means no constraint at the board
> + level.
This does not match Documentation/devicetree/bindings/spi/spi-bus.txt,
which says the default is 1.
As these properties are handled by the SPI core in of_spi_parse_dt, why
would you want to deviate?
Commenting to the question in the cover letter: what would be the
purpose of spi-max-bus-width?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
