Re: [PATCH v7 3/7] drivers/i2c: Add port structure to FSI algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 05/30/2018 04:16 PM, Benjamin Herrenschmidt wrote:
On Wed, 2018-05-30 at 10:47 -0500, Eddie James wrote:
+       if (!list_empty(&i2c->ports)) {
My gosh, this is done already in list_for_each*()
No, list_for_each_entry does NOT check if the list is empty or if the
first entry is NULL.
NULL is never valid for a list. It does however check for an empty list

It does it implicitely in the test part of the for () statement,
checking if the next pointer points back to the head.

Thanks Ben. My mistake on this one; I misread the macro. I will remove the check in v9... going to wait a little for any further comments now.

Thanks,
Eddie


Cheers,
Ben.



--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux