* Faiz Abbas <faiz_abbas@xxxxxx> [180531 10:22]: > On Wednesday 30 May 2018 08:34 PM, Tony Lindgren wrote: > > Looks good to me except I think the reset won't do anything currently > > with ti-sysc.c unless you specfify also "ti,hwmods" for the module? > > > > Can you please check? It might be worth adding the reset function to > > ti-sysc.c for non "ti,hwmods" case and that just might remove the > > need for any hwmod code for this module. > > > > If I understand correctly, this involves adding a (*reset_module) in > ti_sysc_platform_data and defining a ti_sysc_reset_module() in ti-sysc.c > similar to ti_sysc_idle_module(). Right? Well try moving "ti,hwmods" to the module level first. Then reset will happen with enable. Then for simple cases we can add reset directly to ti-sysc.c without pdata callbacks and and drop "ti,hwmods". For more complex cases we need to use reset-simple for the RSTCTRL registers. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
