Hi Clément, On 05/30/2018 03:03 PM, Clément Péron wrote: > From: Colin Didier <colin.didier@xxxxxxxxxxxx> > > Add driver for NXP's EPIT timer used in i.MX 6 family of SoC. > > Signed-off-by: Colin Didier <colin.didier@xxxxxxxxxxxx> > Signed-off-by: Clément Peron <clement.peron@xxxxxxxxxxxx> > --- [snip] > +++ b/drivers/clocksource/timer-imx-epit.c > @@ -0,0 +1,281 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * i.MX EPIT Timer > + * > + * Copyright (C) 2010 Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > + * Copyright (C) 2018 Colin Didier <colin.didier@xxxxxxxxxxxx> > + * Copyright (C) 2018 Clément Péron <clement.peron@xxxxxxxxxxxx> > + */ > + > +#include <linux/clk.h> > +#include <linux/clockchips.h> > +#include <linux/err.h> The included header above still can be removed. I have no more comments about the code, I will try to find time to test the driver, but please don't take it as a promise. -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
